chore: updates heroku env variable to not rely on dyno metadata

Financial-Times · Nov 7, 2023 · fe22b5a · fe22b5a
1 parent b33028c
commit fe22b5a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/packages/app-info/lib/index.js b/packages/app-info/lib/index.js
@@ -136,9 +136,9 @@ module.exports = {
 	cloudProvider:
 		(processType === process.env.AWS_LAMBDA_FUNCTION_NAME
 			? 'aws'
-			: processType === process.env.DYNO
-				? 'heroku'
-				: null) || null
+			: Boolean(process.env.HEROKU_RELEASE_CREATED_AT)
+			? 'heroku'
+			: null) || null
 };
 
 // @ts-ignore

diff --git a/packages/app-info/test/unit/lib/index.spec.js b/packages/app-info/test/unit/lib/index.spec.js
@@ -283,16 +283,16 @@ describe('@dotcom-reliability-kit/app-info', () => {
 			}
 		});
 
-		it('is set to `heroku` if processType is set to `process.env.DYNO`', () => {
-			if (appInfo.processType === process.env.DYNO) {
+		it('is set to `heroku` if `process.env.HEROKU_RELEASE_CREATED_AT` is set to true', () => {
+			if (process.env.HEROKU_RELEASE_CREATED_AT) {
 				expect(appInfo.cloudProvider).toBe('heroku');
 			}
 		});
 
-		describe('when neither `process.env.AWS_LAMBDA_FUNCTION_NAME` or `process.env.DYNO` are defined', () => {
+		describe('when neither `process.env.AWS_LAMBDA_FUNCTION_NAME` or `process.env.HEROKU_RELEASE_CREATED_AT` are defined', () => {
 			beforeEach(() => {
 				jest.resetModules();
-				delete process.env.DYNO;
+				delete process.env.HEROKU_RELEASE_CREATED_AT;
 				delete process.env.AWS_LAMBDA_FUNCTION_NAME;
 				appInfo = require('../../../lib');
 			});