feat: add some basic app info to error pages #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first step towards serving nicer error pages in production. We want to show application information so that a non-engineer would be able to tell which system an error is served by. This doesn't make error pages available in production yet, that'd be a later step if we decide we want to add it. In the meantime this makes the error page more useful.
CyntiBinti
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards serving nicer error pages in production. We want to show application information so that a non-engineer would be able to tell which system an error is served by. This doesn't make error pages available in production yet, that'd be a later step if we decide we want to add it.
In the meantime this makes the error page more useful.
It looks like this: