Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: always log ISO datetime #849

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

rowanmanning
Copy link
Member

This removes the ability to configure the time property of the output logs, setting it to an ISO 8601 formatted string with the current date and time. This is a breaking change because the logs will be different and any tooling that relies on these may break.

There's more detail about why we made this choice in #805.

Resolves #805.

@rowanmanning rowanmanning requested a review from a team as a code owner January 5, 2024 15:08
@rowanmanning rowanmanning force-pushed the logger-default-timestamps branch from d911d6e to 092822e Compare January 5, 2024 16:35

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This removes the ability to configure the time property of the output
logs, setting it to an ISO 8601 formatted string with the current date
and time. This is a breaking change because the logs will be different
and any tooling that relies on these may break.

There's more detail about why we made this choice in #805.

Resolves #805.
@rowanmanning rowanmanning force-pushed the logger-default-timestamps branch from 092822e to 90ceafd Compare January 5, 2024 16:51
@rowanmanning rowanmanning merged commit e12ab9a into main Jan 5, 2024
3 checks passed
@rowanmanning rowanmanning deleted the logger-default-timestamps branch January 5, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make logging ISO timestamps the default
2 participants