chore!: always log ISO datetime #849
Merged
+5
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanmanning
force-pushed
the
logger-default-timestamps
branch
from
d911d6e to
092822e
Compare
CyntiBinti
approved these changes
Jan 5, 2024
This removes the ability to configure the time property of the output logs, setting it to an ISO 8601 formatted string with the current date and time. This is a breaking change because the logs will be different and any tooling that relies on these may break. There's more detail about why we made this choice in #805. Resolves #805.
rowanmanning
force-pushed
the
logger-default-timestamps
branch
from
092822e to
90ceafd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the ability to configure the time property of the output logs, setting it to an ISO 8601 formatted string with the current date and time. This is a breaking change because the logs will be different and any tooling that relies on these may break.
There's more detail about why we made this choice in #805.
Resolves #805.