AWS plugin #770
Open
AWS plugin #770
+2,000
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to pass AWS credentials between tasks and is required for us to build an AwsAssumeRole task
This plugin is used to assume an STS role and provide AWS credentials for other tasks. It stores AWS credentials in the CI state so they can be picked up later. This is required for us to be able to assume different roles across different accounts with Hako, we'll be deploying to separate test and prod AWS accounts in future. Later it makes sense to rework the `serverless` and `upload-assets-to-s3` plugins to use this. I'd rather not actually do this work until we've tested this with Hako. Release-As: 0.1.0 Co-Authored-By: Alex Muller <[email protected]>
rowanmanning
force-pushed
the
aws-plugin
branch
from
3a2c5ef to
2b3b7cb
Compare
rowanmanning
commented
Jan 31, 2025
| const RoleSessionName = `toolkit-${randomUUID()}` | ||
| const WebIdentityToken = process.env.CIRCLE_OIDC_TOKEN_V2 | ||
|
|
||
| const client = new STSClient({ region: 'eu-west-1' }) |
There was a problem hiding this comment.
Hard-coded for now while we're in one region. We suspect this will work even for US deploys because roles are not tied to a region, but let's see
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed, this plugin is used to assume an STS role and provide AWS credentials for other tasks. It stores AWS credentials in the CI state so they can be picked up later.
This is required for us to be able to assume different roles across different accounts with Hako, we'll be deploying to separate test and prod AWS accounts in future.
Later it makes sense to rework the
serverlessandupload-assets-to-s3plugins to use this. I'd rather not actually do this work until we've tested this with Hako.Note the
Release-As: 0.1.0in the commit that adds the plugin. This is so we can test further before a stable release. Right now we tested a JS version of this plugin here. It successfully outputs AWS credentials to the CircleCI job here.See-Also: CPREL-1270
Checklist:
feat(circleci): add support for nightly workflows,fix: set Heroku app name for staging apps too