Merge pull request #54 from Financial-Times/upgrade-to-node-v12

Upgrade to Node v12
Financial-Times · Feb 19, 2021 · a87196a · a87196a
2 parents dbfee7e + 7473ca8
commit a87196a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -3,15 +3,10 @@
 
 references:
 
-  container_config_node8: &container_config_node8
+  container_config_node: &container_config_node
     working_directory: ~/project/build
     docker:
-      - image: circleci/node:8-browsers
-
-  container_config_lambda_node8: &container_config_lambda_node8
-    working_directory: ~/project/build
-    docker:
-      - image: lambci/lambda:build-nodejs8.10
+      - image: circleci/node:12
 
   workspace_root: &workspace_root
     ~/project
@@ -60,7 +55,7 @@ version: 2
 jobs:
 
   build:
-    <<: *container_config_node8
+    <<: *container_config_node
     steps:
       - checkout
       - run:
@@ -90,7 +85,7 @@ jobs:
             - build
 
   test:
-    <<: *container_config_node8
+    <<: *container_config_node
     steps:
       - *attach_workspace
       - run:
@@ -106,7 +101,7 @@ jobs:
           destination: test-results
 
   publish:
-    <<: *container_config_node8
+    <<: *container_config_node
     steps:
       - *attach_workspace
       - run:

diff --git a/.nvmrc b/.nvmrc
@@ -0,0 +1 @@
+12
diff --git a/package.json b/package.json
@@ -23,7 +23,7 @@
     "snyk": "^1.167.2"
   },
   "engines": {
-    "node": ">=6.0.0"
+    "node": "12.x"
   },
   "scripts": {
     "prepare": "npx snyk protect || npx snyk protect -d || true"