Refactor teaser snapshots #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-like-robots
commented
Jun 3, 2019
| }); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I'm being quite lazy here by not writing some actual tests but this does preserve the same level of testing as we have with the automated snapshot generation.
debugwand
approved these changes
Jun 3, 2019
rowanbeentje
pushed a commit
that referenced
this pull request
Nov 24, 2021
…apshots Refactor teaser snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor demonstrates how to separate a component from the automatic snapshot tests and implement component-level snapshot tests. This helps to uncouple us from the configuration based stories as discussed in #274.
storiesfolder tostorybookto prevent it being found by the automated test setup.