Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPP-1103 Change x-teaser's props to match content-pipeline's Content #733

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

CPP-1103 Change x-teaser's props to match content-pipeline's Content #733

wants to merge 4 commits into from

Commits on Jul 21, 2023

  1. feat!: rename image prop to mainImage

    @ivomurrell
    ivomurrell committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    262a323 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. feat!: move some teaser-specific parameters into metadata object

    @ivomurrell
    ivomurrell committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    66b3fca View commit details
    Browse the repository at this point in the history

  2. refactor: add explicit types for teaser's relativeUrl field

    @ivomurrell
    ivomurrell committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    10b3a8d View commit details
    Browse the repository at this point in the history

  3. refactor: simplify some teaser code with optional chaining 

    Now that we are using some nested objects in x-teaser with the
introduction of the `teaserMetadata` field, the defensive property
accesses we were employing previously have got quite verbose. Let's make
use of the more modern optional chaining syntax – which babel supports –
to simplify this logic.
    @ivomurrell
    ivomurrell committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    71adb9c View commit details
    Browse the repository at this point in the history