ELES-1362 share highlight preview when copying a link #787
+39
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarbassam88
force-pushed
the
ELES-1362-share-highlight-preview-when-copying-a-link
branch
from
a4f0314
to
bf63df4
Compare
omarbassam88
changed the title
|
Change request: Would be nice to update the properties section in the README |
ytcleon
requested changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality to include the highlights when copying the link for sharing the article.
If the user chooses to not include the highlights in the shared link, we only copy the shortened link for the article.
On the other hand, if the user chooses to include the highlights, the shared text is the highlight (trimmed to 30 words) and the shortened link.