fix: change docker image version to fix build error #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
170210
requested review from
tkxkd0159,
zemyblue,
0Tech and
jaeseung-bae
as code owners
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
ulbqb
previously approved these changes
Jan 25, 2024
Signed-off-by: 170210 <[email protected]>
jaeseung-bae
approved these changes
Jan 26, 2024
ulbqb
approved these changes
Jan 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the build error that occurs after bumping up the Go version from 1.18 to 1.20, caused by #241
Description
Without this PR, we cannot build a Docker image of Finschia.
The reason is golang:1.20-alpine is using alpine3.19, while alpine3.19 upgraded the libc version which includes the following PR: rust-lang/libc#2935
So, this PR changes the Docker image version and sets it to golang:1.20-alpine3.17.
closes: #314
Motivation and context
How has this been tested?
You can try
make docker-build ARCH=arm64ormake docker-buildto build docker image locally.Screenshots (if appropriate):
Checklist:
CHANGELOG.md