Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added upload multiple images from local storage feature #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ganeshsp1
Copy link
Contributor

Added an option to upload multiple images from the gallery, such that the user can click images before hand and upload them all together. The images will be uploaded in the background.

UI Change : New FloatingActionButton to Upload Images.
New Pub dependency Added :multi_media_picker - to select and upload multiple images.
Code Change has been integrated in the camera.dart file to resuse the code for uploading images to firebase storage

@ganeshsp1 ganeshsp1 changed the title Added Upload Images Feature Added upload multiple images from local storage feature May 25, 2019
@ganeshsp1
Copy link
Contributor Author

Updated Readme to correct service_account_key.json file name to service-account-key.json since the former causes an exception while uploading videos
{ Error: ENOENT: no such file or directory, open '/srv/lib/service-account-key.json'
errno: -2,
code: 'ENOENT',
syscall: 'open',
path: '/srv/lib/service-account-key.json' }

Hence found that the correct file name should be service-account-key.json as opposed to what was mentioned in the readme.
Also this caused other issues since the video was not converted, but still the number of images was updated and showed incorrect numbers.

Copy link
Contributor

@prakhar1989 prakhar1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ganesh! Thanks for taking the time to send in a pull-request with your contributions! I've left a couple of comments so that we can see what the UI changes look like.

README.md Outdated Show resolved Hide resolved
flutter-app/lib/labelscreen.dart Outdated Show resolved Hide resolved
@ganeshsp1
Copy link
Contributor Author

Please find the screenshots for the Multiple Image Upload Feature

Image 1
WhatsApp Image 2019-05-30 at 2 07 52 AM (2)

Image 2
WhatsApp Image 2019-05-30 at 2 07 52 AM (1)

Image 3
WhatsApp Image 2019-05-30 at 2 07 52 AM

Image 4
WhatsApp Image 2019-05-30 at 2 09 00 AM

@ganeshsp1 ganeshsp1 closed this May 30, 2019
@ganeshsp1 ganeshsp1 reopened this May 30, 2019
@Eyesonly88
Copy link

Hi there, this is a very useful PR, can someone please merge it?

@Eyesonly88
Copy link

@prakhar1989 @ganeshsp1

Copy link
Contributor

@prakhar1989 prakhar1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the second screenshot: can we use the app's theme colors instead of the blue?

Navigator.pop(context);
},
child: Text('OK'),
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be a snackbar or a dialog instead? IMO, we can just navigate to the previous screen & show a snackbar informing user that images are being uploaded in the background.

new FloatingActionButton.extended(
icon: const Icon(Icons.add_a_photo),
heroTag: 1,
label: const Text('Add Images'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having two buttons doesn't look that great :( Can we use a FAB menu or just use the icon?

new FloatingActionButton.extended(
icon: const Icon(Icons.file_upload),
heroTag: 2,
label: const Text('Upload Images'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets remove the text, and just use the icons? (as shown here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants