-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added upload multiple images from local storage feature #5
base: master
Are you sure you want to change the base?
Conversation
Updated Readme to correct service_account_key.json file name to service-account-key.json since the former causes an exception while uploading videos Hence found that the correct file name should be service-account-key.json as opposed to what was mentioned in the readme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ganesh! Thanks for taking the time to send in a pull-request with your contributions! I've left a couple of comments so that we can see what the UI changes look like.
Hi there, this is a very useful PR, can someone please merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the second screenshot: can we use the app's theme colors instead of the blue?
Navigator.pop(context); | ||
}, | ||
child: Text('OK'), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be a snackbar or a dialog instead? IMO, we can just navigate to the previous screen & show a snackbar informing user that images are being uploaded in the background.
new FloatingActionButton.extended( | ||
icon: const Icon(Icons.add_a_photo), | ||
heroTag: 1, | ||
label: const Text('Add Images'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having two buttons doesn't look that great :( Can we use a FAB menu or just use the icon?
new FloatingActionButton.extended( | ||
icon: const Icon(Icons.file_upload), | ||
heroTag: 2, | ||
label: const Text('Upload Images'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets remove the text, and just use the icons? (as shown here)
Added an option to upload multiple images from the gallery, such that the user can click images before hand and upload them all together. The images will be uploaded in the background.
UI Change : New FloatingActionButton to Upload Images.
New Pub dependency Added :multi_media_picker - to select and upload multiple images.
Code Change has been integrated in the camera.dart file to resuse the code for uploading images to firebase storage