Creating package dependency without a version will result in "latest" #104
Conversation
| var versionDep = splitDependency[1]; | ||
| yield return new PackageDependency(splitDependency[0], versionDep); | ||
| } | ||
| yield return (PackageDependency)dep; |
There was a problem hiding this comment.
Isn't this just dependencies.Cast<PackageDependency>() ?
There was a problem hiding this comment.
That does not work for user-defined operators sadly:
https://stackoverflow.com/questions/13316718/explicit-implicit-cast-operator-fails-when-using-linqs-cast-operator
There was a problem hiding this comment.
I don't like this cast operator magic anyway, it's basically hiding the creation of a PackageDependency object here.....why not just new PackageDependency(dep) ? Everyone recognizes that....
There was a problem hiding this comment.
But ok, that's a bigger change.
| var versionDep = splitDependency[1]; | ||
| yield return new PackageDependency(splitDependency[0], versionDep); | ||
| } | ||
| yield return (PackageDependency)dep; |
There was a problem hiding this comment.
I don't like this cast operator magic anyway, it's basically hiding the creation of a PackageDependency object here.....why not just new PackageDependency(dep) ? Everyone recognizes that....
| var versionDep = splitDependency[1]; | ||
| yield return new PackageDependency(splitDependency[0], versionDep); | ||
| } | ||
| yield return (PackageDependency)dep; |
There was a problem hiding this comment.
But ok, that's a bigger change.
ewoutkramer
deleted the
75-packagecontextinstallpackagedependency-with-version-null-should-return-the-latest-version
branch
fixes #75