Merge pull request #35 from TsFreddie/string-fix

Resize string buffer to account for bytes instead of chars
FirstGearGames · May 1, 2022 · 0198aa5 · 0198aa5
2 parents c291e63 + e26cd76
commit 0198aa5
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/Assets/FishNet/Runtime/Serializing/Writer.cs b/Assets/FishNet/Runtime/Serializing/Writer.cs
@@ -423,9 +423,10 @@ public void WriteString(string value)
              * never intentionally inflict allocations on itself. 
              * Reader ensures string count cannot exceed received
              * packet size. */
-            if (value.Length >= _stringBuffer.Length)
+            int valueMaxBytes = _encoding.GetMaxByteCount(value.Length);
+            if (valueMaxBytes >= _stringBuffer.Length)
             {
-                int nextSize = (_stringBuffer.Length * 2) + value.Length;
+                int nextSize = (_stringBuffer.Length * 2) + valueMaxBytes;
                 Array.Resize(ref _stringBuffer, nextSize);
             }