[Serve] multiple submodels serve #298
Merged
+942
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyber-pioneer
changed the title
cyber-pioneer
force-pushed
the
final_serve
branch
4 times, most recently
from
61007c2 to
7b89e05
Compare
cyber-pioneer
force-pushed
the
final_serve
branch
from
3f00d5d to
3b4e708
Compare
cyber-pioneer
force-pushed
the
final_serve
branch
from
fb6204f to
9ab5b39
Compare
cyber-pioneer
force-pushed
the
final_serve
branch
from
38b60e3 to
01529bc
Compare
cyber-pioneer
force-pushed
the
final_serve
branch
from
01529bc to
06152f7
Compare
aoyulong
reviewed
Jan 24, 2025
| if with_test: | ||
| f.write(f'bash -c "$cmd; sync" \n') | ||
| # TODO: need a option to control whether to append or overwrite the output file | ||
| # Now, it always appends to the output file |
There was a problem hiding this comment.
Yes, if there is an option available, users will be satisfied.
| if self.command_line_mode: | ||
| self.user_script = "flagscale/serve/run_vllm.py" | ||
| elif isinstance(entrypoint, str) and entrypoint.endswith(".py"): | ||
| self.user_script = entrypoint | ||
| elif entrypoint is None: |
There was a problem hiding this comment.
Should we require users to provide the entrypoint?
There was a problem hiding this comment.
This is an option. Models pipeline can be built via user's entrypoint file or yaml config.
flagscale/serve/core/dag.py
Outdated
| from flagscale.logger import logger | ||
|
|
||
|
|
||
| class Builder: |
There was a problem hiding this comment.
Builder for what? I believe the name should be more specific.
flagscale/serve/core/dag.py
Outdated
Comment on lines
49
to
56
| def check_and_get_port(self, target_port=None, host="0.0.0.0"): | ||
| """ | ||
| Check if a specific port is free; if not, allocate a free port. | ||
| :param target_port: The port number to check, default is None. | ||
| :param host: The host address to check, default is "0.0.0.0". | ||
| :return: A tuple (is_free, port), where `is_free` indicates if the target port is free, | ||
| and `port` is the allocated port (target_port if free, or a new free port). | ||
| """ |
There was a problem hiding this comment.
The code should be placed in the utilities so that it can be reused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
New Feature
Description
Given many submodules. Simply configure the keywords of the submodules, including resource allocation and interdependencies among the submodels.
Given many well-connected nodes. Simply configure the keywords of the nodes, including resource type and address messages.
Serve test case contains 2 steps: serve and call.