Fix issue #1092 for deleting measurements, as well #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…noses/forecasts) Signed-off-by: Nicolas Höning <[email protected]>
Signed-off-by: Nicolas Höning <[email protected]>
Flix6x
reviewed
Jan 3, 2025
| @@ -38,6 +38,8 @@ Infrastructure / Support | |||
| Bugfixes | |||
| ----------- | |||
| * Fix table sorting on the assets, accounts and users page (regression from `PR #988 <https://github.com/FlexMeasures/flexmeasures/pull/988>`_) [see `PR #1239 <https://github.com/FlexMeasures/flexmeasures/pull/1239>`_, `PR #1242 <https://github.com/FlexMeasures/flexmeasures/pull/1242>`_, `PR #1248 <https://github.com/FlexMeasures/flexmeasures/pull/1248>`_, `PR #1247 <https://github.com/FlexMeasures/flexmeasures/pull/1247>`_ and `PR #1272 <https://github.com/FlexMeasures/flexmeasures/pull/1272>`_] | |||
| * Fix `flexmeasures delete measurements` and `flexmeasures delete prognoses` which had an error in counting affected rows after SQLAlchemy2.0 upgrade [see `PR #1095 <https://github.com/FlexMeasures/flexmeasures/pull/1095>`_ and `PR #1303 <https://github.com/FlexMeasures/flexmeasures/pull/1303>`_] | |||
There was a problem hiding this comment.
Non-urgent friendly reminder: rst syntax uses double slanted quotes.
Flix6x
pushed a commit
that referenced
this pull request
Jan 17, 2025
* Fix issue #1092 for deleting measurements, as well (1095 handled prognoses/forecasts) Signed-off-by: Nicolas Höning <[email protected]> * add changelog entry Signed-off-by: Nicolas Höning <[email protected]> --------- Signed-off-by: Nicolas Höning <[email protected]> (cherry picked from commit bf6ff0d) Signed-off-by: F.N. Claessen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running
flexmeasures delete measurementswas broken, also and that was left out of #1095. That only handled deleting forecasts.See #1092
How to test
Run the command on some beliefs you can live without.