Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2421 feat: added ability to message recipient without valid public key #2429

Merged

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Nov 8, 2023

This PR added ability to message recipient without valid public key

close #2421 // if this PR closes an issue

Screen.Recording.2023-11-08.at.10.00.26.AM.mov

Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226
Copy link
Collaborator Author

@sosnovsky I implemented like above one.
I think this one might be sufficient? (Allow user to send encrypted/password-protected message/cancel).
Prefixing text(like Hi, i tried to send you encrypted message...) is also a good idea (need to add extra logic though) but I think above implementation might be sufficient.
Let me know your thought.

@sosnovsky
Copy link
Collaborator

@sosnovsky I implemented like above one. I think this one might be sufficient? (Allow user to send encrypted/password-protected message/cancel). Prefixing text(like Hi, i tried to send you encrypted message...) is also a good idea (need to add extra logic though) but I think above implementation might be sufficient. Let me know your thought.

Yes, such implementation is simpler and good enough, allowing users to send messages for recipients even with invalid key.

I just noticed that Web portal password added section isn't visible when sending password message to recipient with invalid key:
Screenshot 2023-11-08 at 22 36 09

@ioanmo226 ioanmo226 marked this pull request as ready for review November 13, 2023 19:23
@ioanmo226
Copy link
Collaborator Author

@sosnovsky Ready for review. Please check

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, just need to add back restriction for enterprise builds

@ioanmo226 ioanmo226 requested a review from sosnovsky November 14, 2023 13:42
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now, thanks!

@sosnovsky sosnovsky merged commit f8d7f1a into master Nov 14, 2023
5 checks passed
@sosnovsky sosnovsky deleted the 2421-add-ability-to-message-recipient-without-valid-public-key branch November 14, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to message recipient without valid public key
2 participants