-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2421 feat: added ability to message recipient without valid public key #2429
#2421 feat: added ability to message recipient without valid public key #2429
Conversation
@sosnovsky I implemented like above one. |
Yes, such implementation is simpler and good enough, allowing users to send messages for recipients even with invalid key. I just noticed that |
FlowCrypt/Controllers/Compose/Extensions/ComposeViewController+TableView.swift
Show resolved
Hide resolved
@sosnovsky Ready for review. Please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, just need to add back restriction for enterprise builds
FlowCrypt/Controllers/Compose/Extensions/ComposeViewController+ErrorHandling.swift
Outdated
Show resolved
Hide resolved
appium/tests/specs/mock/composeEmail/SendEmailToRecipientWithoutPublicKey.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great now, thanks!
This PR added ability to message recipient without valid public key
close #2421 // if this PR closes an issue
Screen.Recording.2023-11-08.at.10.00.26.AM.mov
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):