#2432 Fix: error when decrypting pgpmime with inline image #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosnovsky
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Message is decrypted without errors, but I can't open attachment from PGP/MIME message with inline image for flowcrypt-ios #2432 thread.
It's an image, so attachment preview should work, but app only proposes to download attachment. And even after download it can't be opened, because it's downloaded as encrypted file (ending at .jpg.pgp).
Can you please check this issue? If it's a small fix then we can include it in the current PR, otherwise I'll work on it in a separate issue.
FlowCrypt/Controllers/Threads/ThreadDetailsViewController.swift
Outdated
Show resolved
Hide resolved
sosnovsky
deleted the
2432-error-when-decrypting-pgpmime-message-with-inline-image
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed error when decrypting pgpmime with inline image
close #2432 // if this PR closes an issue
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):