Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error logging when provisioning devices with token #338

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

hardillb
Copy link
Contributor

fixes #337

Description

Errors from the _getDeviceInfo API call were being swallowed

This attaches them to the new Error being thrown so they can be shown

Related Issue(s)

#337

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from Steve-Mcl January 15, 2025 15:10
@hardillb hardillb self-assigned this Jan 15, 2025
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of the error cause feature (I'm ashamed to admit I only learnt about this recently 😅)

@hardillb hardillb merged commit 68eb773 into main Jan 17, 2025
4 checks passed
@hardillb hardillb deleted the better-error branch January 17, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device agent swallows SSL cerificate errors if using provisioning token
2 participants