Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass files api for docker #108

Merged
merged 4 commits into from
Aug 28, 2024
Merged

First pass files api for docker #108

merged 4 commits into from
Aug 28, 2024

Conversation

hardillb
Copy link
Contributor

Description

Adds the driver interface to FlowFuse/nr-launcher#273

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb self-assigned this Aug 16, 2024
@hardillb hardillb requested a review from Steve-Mcl August 19, 2024 13:17
@hardillb
Copy link
Contributor Author

@Steve-Mcl Like k8s, please review but not merge

@hardillb
Copy link
Contributor Author

Localfs for comparison FlowFuse/driver-localfs#144

Steve-Mcl
Steve-Mcl requested changes Aug 22, 2024
View reviewed changes
docker.js Outdated Show resolved Hide resolved
docker.js Outdated Show resolved Hide resolved
@hardillb hardillb mentioned this pull request Aug 27, 2024
Closed
@hardillb hardillb marked this pull request as ready for review August 27, 2024 13:31
@hardillb hardillb requested a review from Steve-Mcl August 27, 2024 13:31
@hardillb hardillb merged commit 1e8464c into main Aug 28, 2024
1 check passed
@hardillb hardillb deleted the add-file-api branch August 28, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steve-Mcl Steve-Mcl Steve-Mcl approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardillb @Steve-Mcl