Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

both storage options required (enabled & path) #111

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Sep 5, 2024

Description

While checking on configuration bug I noticed this should be both not or for enabled and the path

The docs do say both is required, but this is to make it explicit

Related Issue(s)

NA

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

While checking on configuration bug I noticed this should be both not or
@hardillb hardillb requested a review from knolleary September 5, 2024 12:00
@hardillb hardillb self-assigned this Sep 5, 2024
@hardillb hardillb changed the title both storage options required (enabled & path both storage options required (enabled & path) Sep 5, 2024
@knolleary knolleary merged commit 7d57a6d into main Sep 5, 2024
1 check passed
@knolleary knolleary deleted the hardillb-patch-1 branch September 5, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants