Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container loading for new module scopes #3141

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Conversation

knolleary
Copy link
Member

@knolleary knolleary commented Nov 28, 2023

Description

This updates the core to pick up the new @flowfuse scoped localfs module.

It updates the container loading mechanism to map the config value to the module name more explicitly rather than rely on string concatenation. This also allows us to incrementally migrate the drivers.

Before merge:

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (60c6005) 1.98% compared to head (b881cfe) 39.81%.
Report is 21 commits behind head on main.

❗ Current head b881cfe differs from pull request most recent head fb7ddf9. Consider uploading reports for the commit fb7ddf9 to get more accurate results

Files Patch % Lines
forge/containers/index.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main    #3141       +/-   ##
==========================================
+ Coverage   1.98%   39.81%   +37.82%     
==========================================
  Files        579      579               
  Lines      21123    21122        -1     
  Branches    5079     5077        -2     
==========================================
+ Hits         420     8410     +7990     
+ Misses     20703    12712     -7991     
Flag Coverage Δ
backend 75.39% <66.66%> (?)
frontend 1.98% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary changed the title Update container loading for new module scopes - localfs Update container loading for new module scopes Nov 28, 2023
@knolleary knolleary requested a review from hardillb November 29, 2023 14:40
@knolleary knolleary merged commit 2004f93 into main Nov 29, 2023
5 checks passed
@knolleary knolleary deleted the update-driver-scope branch November 29, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants