Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bill of Materials - Detailing Dependencies #4479

Merged
merged 25 commits into from
Sep 18, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Sep 12, 2024

Description

Implemented Design: Draft 1 from parent issue

Related Issue(s)

closes #4363

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this Sep 12, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.14%. Comparing base (f6f8853) to head (0048a28).
Report is 26 commits behind head on 4362-bom-api.

Additional details and impacted files
@@              Coverage Diff              @@
##           4362-bom-api    #4479   +/-   ##
=============================================
  Coverage         78.14%   78.14%           
=============================================
  Files               299      299           
  Lines             14251    14251           
  Branches           3232     3232           
=============================================
  Hits              11136    11136           
  Misses             3115     3115           
Flag Coverage Δ
backend 78.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepavitt joepavitt changed the title 4363 Bill of Materials UI Bill of Materials - Detailing Dependencies Sep 17, 2024
@joepavitt
Copy link
Contributor

joepavitt commented Sep 17, 2024

So, the UI is great, although I've noticed that not all of my dependencies are listed. For example, I installed @flowfuse/node-red-dashboard in my instance, and it doesn't show in the dependencies list.

What limitations are expected here @Steve-Mcl?

@joepavitt
Copy link
Contributor

Rubber ducked with Steve - it's because I was running a local stack with my Dashboard development environment setup. Anything installed via FlowFuse > Settings > Palette, or the Palette Manager works great.

@joepavitt
Copy link
Contributor

Have opened #4501 to ensure we include docs before the over-arching epic can be considered completed, but this is a great addition.

I know it was built on my designs, but do think it's a little cleaner like this, so have made appropriate CSS changes:

Screenshot 2024-09-17 at 16 48 18

@joepavitt
Copy link
Contributor

Awaiting final tests to pass, but this is great

@joepavitt joepavitt merged commit 0678d94 into 4362-bom-api Sep 18, 2024
14 checks passed
@joepavitt joepavitt deleted the 4363_bill-of-materials-frontend branch September 18, 2024 15:31
@joepavitt
Copy link
Contributor

@cstns please make sure we get a changelog entry for this please, and follow up with the #4501 for documentation

@cstns
Copy link
Contributor Author

cstns commented Sep 18, 2024

Created FlowFuse/website#2565 for the changelog entry, will tackle both changelog & docs first thing tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants