-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4563 replace instance and audit logs dropdowns #4567
base: main
Are you sure you want to change the base?
Conversation
…instance-and-audit-logs-dropdowns
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4567 +/- ##
=======================================
Coverage 78.30% 78.30%
=======================================
Files 302 302
Lines 14360 14360
Branches 3265 3265
=======================================
Hits 11244 11244
Misses 3116 3116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
'team.id' () { | ||
this.loadUsers() | ||
'team.id': { | ||
handler: function (teamId) { if (teamId) this.loadUsers() }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed a bug where team members were not loaded when the page loaded, resulting in an empty users list
…instance-and-audit-logs-dropdowns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve @cstns but firstly, I am curious why we are only doing the Envent Type and User but not the Event Scope immediately above?
Should the items on a single page not be done in tandem?
Happy to proceed, but thought to ask in case it was an oversight.
It wasn't oversight, It's just the crazy way I managed to split the input's when creating the tasks, Should be fixed by #4561 |
Description
Related Issue(s)
closes #4563
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label