-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Introduce Node-RED 4.0.0-beta
container images
#351
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to change the base image, but otherwise good.
node-red-container/Dockerfile-4.0
Outdated
@@ -0,0 +1,35 @@ | |||
FROM nodered/node-red-dev:4.0.0-beta.1-18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FROM nodered/node-red-dev:4.0.0-beta.1-18 | |
FROM nodered/node-red-dev:4.0.0-beta.1 |
We should be using the NodeJS v20 build not the NodeJS v18
@ppawlowski Sorry I missed this earlier but this also needs adding to the build-containers GHA https://github.com/FlowFuse/helm/blob/main/.github/workflows/build-containers.yml |
Description
This pull request adds a Dockerfile for Node-RED 4.0.0-beta.1-18 and build/upload workflows for building and uploading Node-RED 4.0.x container images.
Related Issue(s)
#350
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label