Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Introduce Node-RED 4.0.0-beta container images #351

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Conversation

ppawlowski
Copy link
Contributor

Description

This pull request adds a Dockerfile for Node-RED 4.0.0-beta.1-18 and build/upload workflows for building and uploading Node-RED 4.0.x container images.

Related Issue(s)

#350

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested a review from hardillb March 15, 2024 11:52
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change the base image, but otherwise good.

@@ -0,0 +1,35 @@
FROM nodered/node-red-dev:4.0.0-beta.1-18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FROM nodered/node-red-dev:4.0.0-beta.1-18
FROM nodered/node-red-dev:4.0.0-beta.1

We should be using the NodeJS v20 build not the NodeJS v18

@ppawlowski ppawlowski requested a review from hardillb March 15, 2024 12:28
@hardillb hardillb merged commit 6698dd6 into main Mar 15, 2024
33 checks passed
@hardillb hardillb deleted the feat-nodered4 branch March 15, 2024 13:03
@hardillb
Copy link
Contributor

@ppawlowski Sorry I missed this earlier but this also needs adding to the build-containers GHA

https://github.com/FlowFuse/helm/blob/main/.github/workflows/build-containers.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants