-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add initial documentation for each of the modules #6
Conversation
… and `detailed_monitoring_enabled` variables
default = "1.26" | ||
type = string | ||
description = "The desired Kubernetes master version. If you do not specify a value, the latest available version is used." | ||
default = "1.26" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not suggesting we change this at the moment, just wondering if something new would be better as we hope to move prod to 1.26 soon, but irrc this only has a short support life on AWS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I picked up this version since I recall you were locally running FF on this version without issues.
My approach here is to change the default value once we confirm internally that there are no issues with FF on specific Kubernetes version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hardillb in fact, if we can somehow confirm FF compatibility with a higher Kubernetes version then I am fine with setting a different default version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test "scaling" cluster is currently running 1.26 and I think that is newest we have actually tested recently.
My cluster is running 1.24 and needs upgrading. Leave this as it is for now, but we should open a ticket in CloudProject to upgrade the scaling cluster as a test and then update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but not merged, please check my comment about the K8s version
Description
This pull request adds module documentation for the eks, lb-domain, rds, route53, ses, vpc, and vpc-peering modules. The documentation includes descriptions of the resources used in each module and example usage. Additionally, the main readme file now includes links to the documentation of each module.
Additionally, this PR removes unused variables from the EKS module.
Related Issue(s)
#5
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label