Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage: Add blueprint section #3014

Closed
wants to merge 4 commits into from
Closed

Conversation

Yndira-E
Copy link
Contributor

@Yndira-E Yndira-E commented Mar 6, 2025

Description

This is part of the changes we'll be introducing to the homepage as described here.

Related Issue(s)

#2796

Checklist

  • I have read the contribution guidelines
  • I have considered the performance impact of these changes
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated

@Yndira-E Yndira-E force-pushed the homepage-blueprints-section branch 6 times, most recently from 6f9f9f7 to 18d4a3f Compare March 6, 2025 11:51
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Images automagically compressed by Calibre's image-actions

Compression reduced images by 24.2%, saving 75.43 KB.

Filename Before After Improvement Visual comparison
src/images/home/blueprints/historical-data-dashboard.png 237.37 KB 188.81 KB -20.5% View diff
src/images/home/blueprints/screenshot-crud-flow.png 73.86 KB 46.99 KB -36.4% View diff

1642 images did not require optimisation.

@Yndira-E Yndira-E force-pushed the homepage-blueprints-section branch from f82776e to ec8f24d Compare March 6, 2025 12:29
@Yndira-E Yndira-E force-pushed the homepage-blueprints-section branch from ec8f24d to ece04b6 Compare March 6, 2025 13:02
@Yndira-E Yndira-E requested a review from ZJvandeWeg March 6, 2025 13:06
@Yndira-E Yndira-E marked this pull request as ready for review March 6, 2025 13:06
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Images automagically compressed by Calibre's image-actions

Compression reduced images by 24.2%, saving 75.43 KB.

Filename Before After Improvement Visual comparison
src/images/home/blueprints/historical-data-dashboard.png 237.37 KB 188.81 KB -20.5% View diff
src/images/home/blueprints/screenshot-crud-flow.png 73.86 KB 46.99 KB -36.4% View diff

1642 images did not require optimisation.

@@ -4,7 +4,7 @@ subtitle: Detailed instructions on how to create a Node-RED dashboard that shows
description: Discover how to build a Historical Data Dashboard with InfluxDB and Node-RED. Capture, store, and visualize data for insightful analysis.
date: 2023-07-18
authors: ["andrew-lynch"]
image: blog/2023/07/images/historical-data-dashboard.png
image: blog/2023/07/images/historical-data_dashboard.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the image in the blueprint repo has the same name, so this one was overwriting the blueprint one.

@ZJvandeWeg ZJvandeWeg requested a review from knolleary March 6, 2025 15:17
@@ -0,0 +1,15 @@
- title: "CRUD MongoDB API"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume that this data file only need 3 keys, which are pointers to blueprints in the repo we already import. Why have you chosen to duplicate these values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially duplicated the values and even the images to avoid potential build errors in the Netlify preview environment, which doesn't have access to the imported repository during preview builds. I've resolved this issue by using an if statement to check for the existence of the blueprints. If the blueprints are not found, they are simply not displayed, and no error is thrown. Here's the new PR with the updated approach.

@Yndira-E Yndira-E closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants