Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Disable clipboard and change watcher in details view #196

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

Sebobo
Copy link
Member

@Sebobo Sebobo commented Jul 21, 2023

They don’t have any real use here

@Sebobo Sebobo requested a review from grebaldi July 21, 2023 08:27
@Sebobo
Copy link
Member Author

Sebobo commented Jul 21, 2023

Hi @grebaldi, do you remember why you added them to this view?
IMO the clipboard watcher doesn't do anything here, as the clipboard is not visible, and the change monitor only if the viewed asset is changed, but it wouldn't affect the editor that much.

Copy link
Member

@grebaldi grebaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sebobo,

I think I just didn't question them when I adapted (to not say "copied" 😅) the view from elsewhere.

Removal LGTM 👍

@Sebobo
Copy link
Member Author

Sebobo commented Jul 21, 2023

That's what I suspected, thx :)

@Sebobo Sebobo merged commit 84078eb into main Jul 21, 2023
@Sebobo Sebobo deleted the bugfix/disable-watch-in-details-view branch July 21, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants