-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: change button style of AssetAction buttons too neutral #199
base: main
Are you sure you want to change the base?
TASK: change button style of AssetAction buttons too neutral #199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way you also change their look in the list of the media module. There I intentionally used the transparent versions.
That means you should set the button type as variable here and make it dependent on where it's being used.
Thx, will check it asap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment
Hm. Like that? This also doesent look good IMO.. or maybe I have to give it a little time and think about it. demo.mov |
No, with your change there were not transparent by default anymore for me. I would prefer if they stay transparent "until" they are hovered. |
resolves: #198
What I did
See: #198
If the buttons are transparent it makes them a bit hard to see especially if you have a file with a white background, for example. And since the icons themselves already have a white color, it doesent look very nice on a transparent background.
Besides, it simply makes a nicer impression in general in my opinion.
But I am of course open for opinions !
How I did it
Changed the style of the AssetActions buttons from transparent too neutral.
How to verify it
Before
After