Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix next overworld bug #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix next overworld bug #6

wants to merge 1 commit into from

Conversation

burlito
Copy link

@burlito burlito commented Oct 24, 2013

when i try go to next overworld by path, it will end up with error
"Warning : Overworld not found world_2". This commit should fix this.

when i try go to next overworld by path, it will end up with error
"Warning : Overworld not found world_2". This commit should fix this.
@burlito
Copy link
Author

burlito commented Oct 24, 2013

Hi,

I found this bug:
When i finished first overworld game have problem find next overworld. It print this error message: Warning : Overworld not found world_2
I'm using ubuntu linux, and player nevest version from github.
So i've done little researche and found this: m_path in maps was like that: world_2 but m_path in overworld manager was with / at begining so like that /world_2. I've no idea if this is OS specific or not but I made this workaround bugfix.

Maybe is good idea delete / from m_path in overworld manager too. But I wasn't sure this will not break anything.

Btw: I'm sorry for my terrble english.

@Quintus
Copy link

Quintus commented Oct 24, 2013

I doubt you will get much response from this repository. @FluXy, the repo’s owner, doesn’t work on SMC anymore and @tristanheaven shows up rarely. If you make your patches applicable to my fork I will review and comment on them.

Vale,
Quintus

@datahead8888
Copy link

@Quintus - I just was wondering - were we able to make use of this patch?
@burlito - we would love to have you join our team if you're interested.
We're all developing out of https://github.com/Secretchronicles/TSC now. We're getting close to a new release of the game.

@Quintus
Copy link

Quintus commented Oct 3, 2014

The problem is gone in TSC as far as I know.

Vale,
Quintus

@burlito
Copy link
Author

burlito commented Oct 3, 2014

Hi,

On 10/03/2014 02:10 AM, datahead8888 wrote:

@Quintus https://github.com/Quintus - I just was wondering - were we
able to make use of this patch?

Sure, but as far as I remembered it's kinda poorly writen. However you
can still add this parch in to your tree now, and when I'll have more
time I'll rewrite it.

Do you need me resend pull request to your repository?

On 10/03/2014 02:10 AM, datahead8888 wrote:

@burlito https://github.com/burlito - we would love to have you join
our team if you're interested.
We're all developing out of https://github.com/Secretchronicles/TSC now.
We're getting close to a new release of the game.

Sure I'would like to join your team. If you have som tasks you would
like to assignm me go ahead. However I have to warn you I have a quite
tight schedulle until end of this year so I'm not sure how much I'll be
help for your team, but when you assignm me som tasks we will see.

ps: sorry for my not so good English but as you can see, I'm not native
speaker.

Kind regards,
b.

@Quintus
Copy link

Quintus commented Oct 3, 2014

Sure I'would like to join your team.

Then I would recommend you to join our IRC channel at #secretchronicles on freenode.net :-) There’s also a mailinglist available.

Vale,
Quintus

@datahead8888
Copy link

If you have som tasks you would like to assignm me go ahead. However I have to warn you I have a quite tight schedulle until end of this year so I'm not sure how much I'll be help for your team, but when you assignm me som tasks we will see.

Tasks are listed at https://github.com/Secretchronicles/TSC/issues
Coding standard tasks such as Secretchronicles#8 tend to be pretty low commitment.
If you want something a little more aggressive, Secretchronicles#79 will allow you to use most of the enemy code Quintus wrote while changing some rules with it and doing some configurations. This is a task to create a new version of an enemy.

Bugsbane and I have time limitations, too, so you are not alone. Please do post on the ticket in github so that we know if you are working on something or if you stop on a task for a while. This prevents duplicated work.

Sure I'would like to join your team.
We'll be waiting for you.... :P

@pcworld
Copy link

pcworld commented Jan 28, 2015

There's a workaround on the Debian bugtracker which only involves modifying configuration files, so you don't have to recompile SMC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants