Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking change] Update propagation of stack action #168

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Update

d3f9759
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

[breaking change] Update propagation of stack action #168

Update
d3f9759
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / Xcode test results succeeded Dec 20, 2023 in 0s

Xcode test results

Testing workspace FluidInterfaceKit with scheme FluidInterfaceKit-Package

Summary

TotalSuccess PassedFailure FailedSkipped SkippedExpected Failure Expected Failure⏱️ Time
31310000.14s

Test Summary

FluidStackTests

  • Device: iPhone 15 Pro, 17.0.1 (21A342)
  • SDK: Simulator - iOS 17.0, 17.0
TestTotalSuccessFailureSkippedExpected Failure
test-class FluidLocalEnvironmentTests11000
test-class FluidStackControllerTests2121000
test-class FluidViewControllerTests66000
test-class UIKitPresentationTests11000
test-class UINavigationItemTests11000
test-class UIViewControllerExtensionTests11000

Failure Failures

All tests passed 🎉

Code Coverage

Coverage Covered Executable
FluidGesture 0.00 % 0 0
FluidKeyboardSupport 0.00 % 0 0
FluidPictureInPicture 0.00 % 0 0
FluidPortal 0.00 % 0 228
  NativePortalView.swift 0.00 % 0 51
  PortalStackView.swift 0.00 % 0 61
  PortalView.swift 0.00 % 0 90
  Logger.swift 0.00 % 0 26
FluidSnackbar 0.00 % 0 0
FluidStack 28.78 % 2385 8287
  ContextualTransitionSourceComponentType.swift 0.00 % 0 36
  FluidViewController.swift 86.16 % 361 419
  ScrollView+Handling.swift 0.00 % 0 97
  UINavigationItem+.swift 100.00 % 11 11
  UIBarButtonItem+.swift 0.00 % 0 33
  FluidPopoverViewController.swift 0.00 % 0 233
  AnyRemovingTransition+noAnimation.swift 72.73 % 8 11
  Logger.swift 64.29 % 18 28
  AnyRemovingTransition.swift 18.42 % 7 38
  AnyAddingTransition.swift 18.42 % 7 38
  CGVector+Magnitude.swift 0.00 % 0 3
  AnyBatchRemovingTransition.swift 19.70 % 53 269
  FluidStackController.swift 80.36 % 794 988
  AnyRemovingTransition+modalIdiom.swift 100.00 % 58 58
  Fluid+withTransaction.swift 91.49 % 43 47
  RemovingTransitionContext.swift 42.27 % 41 97
  BatchRemovingTransitionContext.swift 46.51 % 40 86
  FluidTabBarController.swift 0.00 % 0 6
  UIView+Geometry.swift 0.00 % 0 5
  AnyRemovingTransition+fadeOut.swift 0.00 % 0 40
  MirrorViewProvider.swift 0.00 % 0 205
  AnyAddingTransition+contextualInstagramThreads.swift 0.00 % 0 213
  AnyRemovingInteraction+horizontalDragging.swift 0.00 % 0 995
  AddingTransitionContext.swift 98.78 % 81 82
  UIViewController+.swift 78.69 % 144 183
  CALayer+activeLayer.swift 0.00 % 0 4
  AnyAddingTransition+modalIdiom.swift 100.00 % 66 66
  Debugging.swift 0.00 % 0 207
  SourceCodeLocation.swift 0.00 % 0 4
  AnyAddingTransition+navigationStyle.swift 42.35 % 36 85
  FluidSceneSwitchController.swift 0.00 % 0 4
  TransitionContext.swift 17.50 % 7 40
  FluidWrapperViewController.swift 77.91 % 67 86
  StackingRelation.swift 75.00 % 9 12
  FluidStackContext.swift 34.09 % 15 44
  ReparentingView.swift 0.00 % 0 44
  AnyRemovingTransition+navigationStyle.swift 42.35 % 36 85
  FluidGestureHandlingViewController.swift 16.33 % 57 349
  UIView+.swift 14.95 % 16 107
  BatchApplier.swift 0.00 % 0 16
  AnyAddingTransition+fadeIn.swift 0.00 % 0 187
  AnyAddingTransition+noAnimation.swift 76.92 % 10 13
  FluidExtentionViewController.swift 37.67 % 110 292
  GlobalConfiguration.swift 100.00 % 1 1
  Fluid.swift 19.70 % 39 198
  AnyRemovingTransition+vanishing.swift 0.00 % 0 64
  AnyRemovingInteraction.swift 21.43 % 3 14
  AnyAddingTransition+contextualExpanding.swift 0.00 % 0 266
  AnyRemovingTransition+contextual.swift 0.00 % 0 595
  FluidTransitionViewController.swift 94.12 % 32 34
  FluidSwitchController.swift 0.00 % 0 32
  AnyAddingTransition+popup.swift 0.00 % 0 51
  AnyRemovingInteraction+leftToRight.swift 23.52 % 215 914
  FluidStageViewController.swift 0.00 % 0 252
FluidStackRideauSupport 0.00 % 0 0
FluidStackTests 39.31 % 3871 9848
  ContextualTransitionSourceComponentType.swift 0.00 % 0 36
  UINavigationItemTests.swift 100.00 % 11 11
  FluidViewController.swift 86.16 % 361 419
  ScrollView+Handling.swift 0.00 % 0 97
  UINavigationItem+.swift 100.00 % 11 11
  UIBarButtonItem+.swift 0.00 % 0 33
  FluidPopoverViewController.swift 0.00 % 0 233
  AnyRemovingTransition+noAnimation.swift 72.73 % 8 11
  Logger.swift 64.29 % 18 28
  FluidLocalEnvironmentTests.swift 100.00 % 28 28
  AnyRemovingTransition.swift 18.42 % 7 38
  AnyAddingTransition.swift 18.42 % 7 38
  CGVector+Magnitude.swift 0.00 % 0 3
  AnyBatchRemovingTransition.swift 19.70 % 53 269
  FluidStackController.swift 80.36 % 794 988
  AnyRemovingTransition+modalIdiom.swift 100.00 % 58 58
  Fluid+withTransaction.swift 91.49 % 43 47
  RemovingTransitionContext.swift 42.27 % 41 97
  BatchRemovingTransitionContext.swift 46.51 % 40 86
  FluidViewControllerTests.swift 93.08 % 323 347
  FluidTabBarController.swift 0.00 % 0 6
  UIView+Geometry.swift 0.00 % 0 5
  AnyRemovingTransition+fadeOut.swift 0.00 % 0 40
  MirrorViewProvider.swift 0.00 % 0 205
  AnyAddingTransition+contextualInstagramThreads.swift 0.00 % 0 213
  AnyRemovingInteraction+horizontalDragging.swift 0.00 % 0 995
  AddingTransitionContext.swift 98.78 % 81 82
  UIViewController+.swift 78.69 % 144 183
  CALayer+activeLayer.swift 0.00 % 0 4
  AnyAddingTransition+modalIdiom.swift 100.00 % 66 66
  Debugging.swift 0.00 % 0 207
  SourceCodeLocation.swift 0.00 % 0 4
  AnyAddingTransition+navigationStyle.swift 42.35 % 36 85
  FluidSceneSwitchController.swift 0.00 % 0 4
  TransitionContext.swift 17.50 % 7 40
  FluidWrapperViewController.swift 77.91 % 67 86
  StackingRelation.swift 75.00 % 9 12
  FluidStackContext.swift 34.09 % 15 44
  ReparentingView.swift 0.00 % 0 44
  UIViewControllerExtentionTests.swift 100.00 % 10 10
  AnyRemovingTransition+navigationStyle.swift 42.35 % 36 85
  FluidGestureHandlingViewController.swift 16.33 % 57 349
  BatchApplier.swift 0.00 % 0 16
  AnyAddingTransition+fadeIn.swift 0.00 % 0 187
  FluidStackControllerTests.swift 99.18 % 967 975
  AnyAddingTransition+noAnimation.swift 76.92 % 10 13
  UIView+.swift 14.95 % 16 107
  UIKitPresentationTests.swift 77.78 % 21 27
  FluidExtentionViewController.swift 37.67 % 110 292
  GlobalConfiguration.swift 100.00 % 1 1
  Fluid.swift 19.70 % 39 198
  TreeBuilder.swift 77.30 % 126 163
  AnyRemovingTransition+vanishing.swift 0.00 % 0 64
  AnyRemovingInteraction.swift 21.43 % 3 14
  AnyAddingTransition+contextualExpanding.swift 0.00 % 0 266
  AnyRemovingTransition+contextual.swift 0.00 % 0 595
  FluidTransitionViewController.swift 94.12 % 32 34
  FluidSwitchController.swift 0.00 % 0 32
  AnyAddingTransition+popup.swift 0.00 % 0 51
  AnyRemovingInteraction+leftToRight.swift 23.52 % 215 914
  FluidStageViewController.swift 0.00 % 0 252
FluidTooltipSupport 0.00 % 0 0
Total 34.07 % 6256 18363

Details

Test Details

FluidStackTestsback

FluidLocalEnvironmentTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.07s
Successtest-method testBasic()

FluidStackControllerTests back

SuccessFailureSkippedExpected Failure⏱️
21 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method test_fluidPop_dereference_viewcontroller()
Successtest-method test_fluidPush_make_parent_tree_immediately()
Successtest-method testAddingDuplicated()
Successtest-method testAddingRemovingDefaultBehavior()
Successtest-method testAddingRemovingIncludingRoot()
Successtest-method testFindContext()
Successtest-method testFindStackByIdentifier()
Successtest-method testNavigation()
Successtest-method testOffload_1()
Successtest-method testOffload_2()
Successtest-method testOffload_3()
Successtest-method testPopInStack()
Successtest-method testPropagationActions_push_pop()
Successtest-method testPropagationActions_willBecomeTop()
Successtest-method testRemoving2()
Successtest-method testRemovingRecursively_1()
Successtest-method testRemovingRecursively_2()
Successtest-method testRemovingRecursively_3()
Successtest-method testRemovingRecursively_4()
Successtest-method testRemovingRecursively_5()
Successtest-method testStackTree()

FluidViewControllerTests back

SuccessFailureSkippedExpected Failure⏱️
6 (100%)0 (0%)0 (0%)0 (0%)0.01s
Successtest-method testComapreNavigationContrller()
Successtest-method testFluidPush()
Successtest-method testNavigationItemFromBody_bar_never_display()

Activities:
  • No bar
  • Set title and displays the bar
Successtest-method testNavigationItemFromBody_has_bar()

Activities:
  • Displays navigation-bar
  • Request hide the bar
Successtest-method testNavigationItemFromBody_no_bar()
Successtest-method testNavigationItemFromBody_no_bar_and_set_after()

Activities:
  • No bar
  • Set title and displays the bar
  • Set isTopBarHidden = true, bar will hide
  • Set isTopBarHidden = false, bar will be back
  • Set navigationItem.fluidIsEnabled = false, bar will hide

UIKitPresentationTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.06s
Successtest-method testPresentation()

UINavigationItemTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testBarButtonItems()

UIViewControllerExtensionTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testFluidStackControllers_including_self()
View more details on GitHub Actions