Feature/rossby wave demo #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Currently disabled the coriolis source terms to debug an issue on mi210
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
This exercises the constant coriolis procedure previously missed Also, fixed the missing cpu-side source method definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the coriolis force to the linear shallow water equations. To accompany this, I've added an example for simulating planetary Rossby waves.
Documentation for the linear shallow water equations has been updated to include descriptions of the coriolis force implementation with details on how to set the coriolis parameters and geostrophic velocities.
A correctness bug on AMD GPUs (related to unitialized values being amplified by large grid spacing) was found and fixed, as described here