Patches #85

fluidnumerics-joe · 2024-11-27T01:45:14Z

This PR contains various patches that were discovered as being needed during experimentation before today's livestream..

Fix import bug in pyself.model2d
Add sphericalsoundwave procedure for linear euler
Add ReportMetrics and ReportUserMetrics methods
Remove verbose optimization reports output from GNU
Resolution of Entropy coming back negative on pumpkin mesh #75
Resolution of ResetBoundaryCondition does not update sideinfo on GPU #76

This resolves #76

Resolves #75 . Element-corner node ordering can occur either clockwise or counter-clockwise which can result in a positive or negative jacobian. For the purposes of integration, we want to use a positive values jacobian.

codecov · 2024-11-27T02:53:03Z

Codecov Report

Attention: Patch coverage is 91.66667% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/SELF_Model.f90	62.50%	6 Missing ⚠️

📢 Thoughts on this report? Let us know!

Resolves #75 on GPUs

fluidnumerics-joe added 9 commits November 27, 2024 01:40

Add user metrics reporting

bb42d74

Fix import bug; add imageio dependency

c22e027

Use sphericalsoundwave procedure

4085172

Disable optimization reports in default flags

a0c9fb9

Merge remote-tracking branch 'origin/main' into patches

be8f0d2

Formatting

d7a5eb0

Add updatedevice after updating sideinfo

11184a3

This resolves #76

Use abs(J) in entropy calculation.

04d10d5

Resolves #75 . Element-corner node ordering can occur either clockwise or counter-clockwise which can result in a positive or negative jacobian. For the purposes of integration, we want to use a positive values jacobian.

Fix typo

c60141b

fluidnumerics-joe added 3 commits November 27, 2024 03:06

Check for finite final entropy

b248c8f

Change "pressure" to "P"

3d479f6

Use abs(J) in calculateEntropy

3a9a053

Resolves #75 on GPUs

fluidnumerics-joe merged commit aa8ce58 into main Nov 27, 2024
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Patches #85

Patches #85

fluidnumerics-joe commented Nov 27, 2024 •

edited

Loading

codecov bot commented Nov 27, 2024 •

edited

Loading

Patches #85

Patches #85

Conversation

fluidnumerics-joe commented Nov 27, 2024 • edited Loading

codecov bot commented Nov 27, 2024 • edited Loading

Codecov Report

fluidnumerics-joe commented Nov 27, 2024 •

edited

Loading

codecov bot commented Nov 27, 2024 •

edited

Loading