Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop the pipewire loop before destroying the stream #1309

Closed
wants to merge 2 commits into from
Closed

Stop the pipewire loop before destroying the stream #1309

wants to merge 2 commits into from

Conversation

mawe42
Copy link
Member

@mawe42 mawe42 commented Mar 26, 2024

Should fix #1305

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

derselbst
derselbst approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@derselbst derselbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marcus! I'll cherry-pick this to release/2.3 and then merge it back to master.

@derselbst derselbst closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derselbst derselbst derselbst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Pipewire audio output driver does not cleanly destroy when FluidSynth exits
2 participants
@mawe42 @derselbst