Fix a regression introduced by #1314 #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
derselbst
force-pushed
the
revert-1314-issue1312
branch
from
8513a4a
to
bb9bc7a
Compare
derselbst
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #1314, most notable in test case 1 of Christian's new test suite, but also present in others.
Broken behavior introduced by #1314: The short saw wave voice finished processing, but this was not properly attributed and therefore remained in the dsp loop, causing audible sound until the noteoff was received.
Correct behavior before #1314 and with this fix: The saw wave voice is now removed from the dsp loop once it has finished. Voices which are in delay phase (#1312) are still processed to have their dsp phase updated correctly.