Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] rma: Auto-calculate package for serial products #449

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

BernatPForgeFlow
Copy link
Contributor

When returning or delivering a serial product from a RMA, we will calculate by default its package. Later, it can be modified by the user.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #449 (06525e4) into 14.0 (3da8341) will increase coverage by 0.03%.
Report is 2 commits behind head on 14.0.
The diff coverage is 46.15%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             14.0     #449      +/-   ##
==========================================
+ Coverage   80.63%   80.67%   +0.03%     
==========================================
  Files         149      156       +7     
  Lines        4828     4858      +30     
  Branches      888      893       +5     
==========================================
+ Hits         3893     3919      +26     
- Misses        727      730       +3     
- Partials      208      209       +1     
Files Coverage Δ
rma/wizards/rma_make_picking.py 78.37% <46.15%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3da8341...06525e4. Read the comment docs.

@BernatPForgeFlow BernatPForgeFlow force-pushed the 14.0-imp-rma-autocalculate_package branch from 3729b56 to 34d92f4 Compare August 17, 2023 11:07
BernatPForgeFlow and others added 3 commits October 25, 2023 11:23
When returning or delivering a serial product from a RMA, we will calculate by default its package. Later, it can be modyfied by the user.
@BernatPForgeFlow BernatPForgeFlow force-pushed the 14.0-imp-rma-autocalculate_package branch from 06525e4 to ea78ede Compare October 25, 2023 09:23
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks LGTM

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests also

@AaronHForgeFlow AaronHForgeFlow merged commit fcf6da6 into 14.0 Oct 30, 2023
4 checks passed
@AaronHForgeFlow
Copy link
Contributor

@BernatPForgeFlow could forward port this?

@AaronHForgeFlow AaronHForgeFlow deleted the 14.0-imp-rma-autocalculate_package branch October 30, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants