-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] account_move_line_rma_order_line: Migration to 16.0 #453
Merged
AaronHForgeFlow
merged 15 commits into
16.0
from
16.0-mig-account_move_line_rma_order_line
May 9, 2024
Merged
[16.0][MIG] account_move_line_rma_order_line: Migration to 16.0 #453
AaronHForgeFlow
merged 15 commits into
16.0
from
16.0-mig-account_move_line_rma_order_line
May 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexPForgeFlow
force-pushed
the
16.0-mig-account_move_line_rma_order_line
branch
from
October 9, 2023 13:07
fdf7cea
to
8f0c26b
Compare
mariadforgeflow
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine. Just a couple of comments.
account_move_line_rma_order_line/tests/test_account_move_line_rma_order_line.py
Outdated
Show resolved
Hide resolved
…rrect price unit in moves Otherwise the inventory accounting will be completely wrong.
…it hook. As the script was incorrect in previous versions.
…ompute method fails. [IMP] rma: use rma user in tests [FIX] rma_account: move_line_id field string [IMP] rma, rma_account, rma_sale, rma_purchase: tests for stock valuation [FIX] account_move_line_rma_order_line: minor lint, make auto-install [IMP] rma_account_unreconciled: use manager user in test
Otherwise the anglo saxon entries won't be correct. For example, the Interim (Delivered) account should balance after receiving and triggering a refund on a customer rma.
…ccount_move_rma_order_line + clean up commented code
AlexPForgeFlow
force-pushed
the
16.0-mig-account_move_line_rma_order_line
branch
from
May 9, 2024 08:13
8f0c26b
to
5193293
Compare
AaronHForgeFlow
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 16.0
ForgeFlow