[17.0] [MIG] rma_account #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronHForgeFlow
force-pushed
the
17_nc_mig_rma_account
branch
from
7a5a08f
to
534d701
Compare
AaronHForgeFlow
commented
May 6, 2024
|
There are some fields in in the refund wizard that should not show to the user (technical fields that are empty)
|
|
Already includes #519 |
* fix assignment of moves. * default qty in rma lines. * remove account dependency. * test and flake8 fixes.
… supplier [IMP]Separate menus for customer and supplier operations * Add active field to rma operation * Added tests * Fix travis * Fix create supplier rma from customer rma
* remove unneded copy attributes. * simplify action_view methods. * fix wrong naming. * fix misplaced views. * fix wrong count and view actions for rma.orders in invoices. * fix error when installing the module. * remove unneded data update when preparing rma lines from invoice lines. * minor extra fixes.
…sources on rma lines
* fix view * small issue in wizard * modify data file * smaller issues
Otherwise the anglo saxon entries won't be correct. For example, the Interim (Delivered) account should balance after receiving and triggering a refund on a customer rma.
Otherwise the anglo saxon entries won't be correct. For example, the Interim (Delivered) account should balance after receiving and triggering a refund on a customer rma.
Without this, some policies are not being copied from the operation selected when creating new rma line from a rma group. In v16 this patch and the usage of such onchange can be removed in favor of (pre)computed stored editable fields for all policies and configuration in the RMA operation.
when typing the complete invoice name
AaronHForgeFlow
force-pushed
the
17_nc_mig_rma_account
branch
from
8cc034a
to
03cd0b3
Compare
|
Pending to add #537 |
|
Pending to add #538 |
In v16, fiscal_position_id is a computed field, so if we set up the field in the refund creation we are overriding the computed value
|
All FW port completed and working. Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #503
Respected original code & history
Reasons for supersede:
Merge 17.0 was broken after merging and reverting by mistake some pull requests: #483 & #500
History was incorrect showing merge commits within it.
Merge conflicts when trying to manually merge other PRs on top on that one.
Unable to see the changes in the migration commit, making hard for the reviewer to review the code
Sorry for the inconvenience.
@ForgeFlow