Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] rma_sale: fix _get_price_unit to handle dropship cases #540

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

AlexPForgeFlow
Copy link
Contributor

@AlexPForgeFlow AlexPForgeFlow commented Sep 13, 2024

Take negative valuation layers, as are to customers, and we handle dropship cases where will have negative and positive layers.
Up to now with dropship orders, sums from valuation layers were 0 and div by 0 error was raised.

Take negative valuation layers, as are to customers, and we handle dropship cases where will have negative and positive layers
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (53bb77a) to head (93b827f).
Report is 3 commits behind head on 16.0.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             16.0     #540      +/-   ##
==========================================
+ Coverage   80.71%   80.80%   +0.08%     
==========================================
  Files         151      159       +8     
  Lines        5295     5387      +92     
  Branches      856      868      +12     
==========================================
+ Hits         4274     4353      +79     
- Misses        783      793      +10     
- Partials      238      241       +3     
Files with missing lines Coverage Δ
rma_sale/models/rma_order_line.py 72.58% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e9bf62...93b827f. Read the comment docs.

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexPForgeFlow AlexPForgeFlow merged commit bb16136 into 16.0 Nov 6, 2024
4 checks passed
@MiquelRForgeFlow MiquelRForgeFlow deleted the 16.0-fix-HD-12512 branch November 6, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants