[16][FIX] rma: qty received and shipped in case of multiple step reception/expedition #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @florian-dacosta, |
…n/expedition Now the moves are filtered and only 1 move of the chain is selected to compute the quantity (the first one for reception and last one for expedition), so we should no longer ignore those to compute the quantities
florian-dacosta
force-pushed
the
16-fix-qty-received-shipped
branch
from
0dff1e3
to
48c2fed
Compare
|
@DavidJForgeFlow |
DavidJForgeFlow
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Looks good to me! @AaronHForgeFlow can you check this also please!
AaronHForgeFlow
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove changes introduced here : ff0e4fb
Because since this commit, the selection of the move previously in this method have evolved, so now, it breaks the quantity received/shipped in the case of chained moves intead of fixing it...
@AaronHForgeFlow @DavidJForgeFlow