Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update baseUrl for docusaurus site #348

Merged
merged 2 commits into from
Apr 1, 2024
Merged

update baseUrl for docusaurus site #348

merged 2 commits into from
Apr 1, 2024

Conversation

Burnett2k
Copy link
Member

@Burnett2k Burnett2k commented Apr 1, 2024

Description

In order for the site to be rendered correctly in production, the baseUrl needs to be set so that commerce.nearform.com/open-source/react-swipeable triggers the vercel app to open. Setting the baseUrl should fix this. It worked fine in preview environments where baseUrl could be /, but for nearform commerce it is hosted at a specific path /open-source/react-swipeable which needs to be set as the baseUrl.

Once this is merged, the PR preview for the formidable.com site should load correctly. https://formidable-com-next-git-feature-oss-rs-formidable-labs.vercel.app/open-source/react-swipeable

image

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Apr 1, 2024

⚠️ No Changeset found

Latest commit: 02c05e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-swipeable ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 4:39pm

Copy link
Contributor

github-actions bot commented Apr 1, 2024

size-limit report 📦

Path Size
lib/index.js 1.63 KB (0%)
dist/react-swipeable.js 1.72 KB (0%)
es/index.js 1.72 KB (0%)

@Burnett2k Burnett2k merged commit da2277d into main Apr 1, 2024
8 checks passed
@Burnett2k Burnett2k deleted the docusaurus/v2 branch April 1, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants