Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve YTM experience #163

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Improve YTM experience #163

merged 2 commits into from
Aug 28, 2024

Conversation

FoxxMD
Copy link
Owner

@FoxxMD FoxxMD commented Jun 26, 2024

Addresses #156 and #158

@FoxxMD FoxxMD added the safe to test trusted to build image label Jun 26, 2024
@manicExpressive
Copy link

I was experiencing the authentication flakiness mentioned in #158 and this has been working consistently for me for 3 days now (thanks for the docker image to test easily with!)

FoxxMD added 2 commits August 21, 2024 13:14
…to output changes #158

Increasing to INFO makes the signal better for long-running MS processes instead of requiring logging all of DEBUG
…lays #156

Rather than generating our own just use the known "good" history we just compared against to see if this improves consistency.
Copy link
Contributor

📦 A new release has been made for this pull request.

To play around with this PR, pull an image:

  • foxxmd/multi-scrobbler:pr-163
  • foxxmd/multi-scrobbler:pr-163-alpine.

Images are available for x86_64 and ARM64.

Latest commit: 469847e

@FoxxMD
Copy link
Owner Author

FoxxMD commented Aug 21, 2024

Glad to hear that @manicExpressive . I've rebased these changes onto the latest release so I'd recommend pulling the newest docker image when you get a chance. Let me know if it's still working for you after a few more days and I'll get everything merged.

@manicExpressive
Copy link

Auth failed after 2 days which I only just noticed 3 days later because of weekend / conference stuff.

Just reset everything and grabbed a fresh cookie (which I had to "hard refresh" the Chrome instance of music.youtube.com was operating in some kind of cached mode).

This seems like kinda normal "using this cookie for auth is a little sketchy" stuff rather than a bug, happy to report back in a few days again to see if this seems consistent.

@FoxxMD FoxxMD merged commit eeb026a into develop Aug 28, 2024
4 checks passed
@FoxxMD FoxxMD deleted the ytMusicDebug branch August 28, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test trusted to build image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants