Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add avoid chained calls style rule #6

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Add avoid chained calls style rule #6

merged 1 commit into from
Feb 14, 2021

Conversation

Guillemdb
Copy link
Member

closes #5
Signed-off-by: guillemdb [email protected]

@Guillemdb Guillemdb requested a review from TomeuKuma February 11, 2021 18:32
@Guillemdb Guillemdb self-assigned this Feb 11, 2021
@Guillemdb Guillemdb mentioned this pull request Feb 11, 2021
@VicenteAR VicenteAR mentioned this pull request Feb 11, 2021
Copy link
Contributor

@TomeuKuma TomeuKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been totally clear to me.
Thank you @Guillemdb !
How could I edit the content of your commit if i needed?

@Guillemdb
Copy link
Member Author

Guillemdb commented Feb 11, 2021

@TomeuKuma You can propose changes during the code review process as explained here in 6.

Ideally, when you are reviewing a PR the person who opened it should be in charge of implementing the suggested changes. In case that you want to test yourself the code of the PR, you can do it like this:

  1. Checkout the branch of the target pull request. In this case it would be style-guide
    • If the branch exists on your local repository -> git checkout style-guide (the name of the PR branch)
    • If the branch does not exist on your local repository -> git checkout -b style-guide (the name of the PR branch)
  2. git pull origin style-guide -> download the latest changes pushed to the branch.

Please let me know if this works for you.

I opened an issue about documenting this properly in #9

@Guillemdb Guillemdb requested a review from TomeuKuma February 12, 2021 08:18
@Guillemdb Guillemdb added the enhancement New feature or request label Feb 12, 2021
@TomeuKuma
Copy link
Contributor

I think you've answered well the doubt I have relative to issue #5. So it can be merged!
Thanks Guillem!

@TomeuKuma TomeuKuma merged commit a3615ee into main Feb 14, 2021
@TomeuKuma TomeuKuma deleted the style-guide branch February 14, 2021 18:46
@TomeuKuma
Copy link
Contributor

@TomeuKuma You can propose changes during the code review process as explained here in 6.

Ideally, when you are reviewing a PR the person who opened it should be in charge of implementing the suggested changes. In case that you want to test yourself the code of the PR, you can do it like this:

  1. Checkout the branch of the target pull request. In this case it would be style-guide

    • If the branch exists on your local repository -> git checkout style-guide (the name of the PR branch)
    • If the branch does not exist on your local repository -> git checkout -b style-guide (the name of the PR branch)
  2. git pull origin style-guide -> download the latest changes pushed to the branch.

Please let me know if this works for you.

I opened an issue about documenting this properly in #9

I will open an issue about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python style doubt
2 participants