refactor so that jobs are launched in separate docker containers #431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just getting started but I made it a draft PR so that it does not get lost in the sea of branches.
Basically the goal is to make it so that the motuz core containers can be restarted at any time (to deploy code updates, etc) without interrupting running jobs.
The way to do this is to make each copy/check job a separate docker container. You can launch a container within a container if you have Docker installed in the container and /var/lib/docker.sock on the host is mounted to /var/lib/docker.sock in the container.
The child container that gets launched needs to mount the same filesystems as its parent, but this is easy to figure out programmatically using the Docker API.
I've modified the celery container to have docker installed. But there is still a lot more to do: