Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device not reconnecting on lost signal #1

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

dovidgef
Copy link

Hi, I fixed the open issue mentioned here:
ewenchou#8

The issue was that when device goes out of range the script stops tracking the device's rssi, and gets stuck on the last reported rssi number. Additionally even when the device comes back into range or is turned back on, the script does not reconnect to the device.

My fix is a little hacky, but it works.

thanks

@FrederikBolding FrederikBolding self-requested a review January 21, 2019 23:47
@FrederikBolding
Copy link
Owner

Thanks for the pull request, I'll look at it soon!

Copy link
Owner

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@FrederikBolding FrederikBolding merged commit f8e69fb into FrederikBolding:master Jan 28, 2019
@FrederikBolding
Copy link
Owner

Thanks @dovidgef !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants