-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change .stagging background color #1142
base: master
Are you sure you want to change the base?
Conversation
red seem like error message
As someone who doesn't like changes I have to say no please |
Ah... Is there a particular reasoning behind this change? |
I agree that red usually looks like an error message, but between the two screenshots the red looks like it fits better into the theme. What about using a more neutral blue-gray? |
yes, i don't chose blue because of link color (i don't wont to change all the styles) but it's probably a better choice |
use blue-grey
@Hirse I updated pull request |
Could you also post a new image when you update the color, please? Additionally, does this also affect the background of the commit area (when there are changes)? Should it? |
it's the last screenshot #1142 (comment) yes, it also affect commit area (and yes it should, I think) |
red seem like error message