crypto change subject alternate errors to warning #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oroulet
reviewed
Jan 10, 2024
asyncua/crypto/uacrypto.py
Outdated
| err = True | ||
| if hostname is not None: | ||
| san_dns_names = san.value.get_values_for_type(x509.DNSName) | ||
| if hostname not in san_dns_names: | ||
| _logger.error(f'certificate does not contain the hostname in DNSNames {hostname}. Some applications will check this.') | ||
| _logger.warning(f'certificate does not contain the hostname in DNSNames {hostname}. Some applications will check this.') |
There was a problem hiding this comment.
Since you are at it, one should not use fstring for logging....
|
Hi! I was wondering when this would be released to use? I am not seeing this change on the latest version. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only log a warning if the subject alternate name is not as the opc ua specs.
Fixes #1544