Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Migrate deactivated unit to pytest #1577

Conversation

AiyionPrime
Copy link
Contributor

@AiyionPrime AiyionPrime commented Feb 13, 2024

There exists a unittest, which could attest that loading shelf files does currently not work.
This migrates it from unittest to the new pytest format and alters the shelf_file invocation which was provided in __init__() before and is now done in init().

@AiyionPrime AiyionPrime force-pushed the test/migrated_deactivated_unit_to_pytest branch from 79db69f to 61717d5 Compare February 16, 2024 14:26
@AiyionPrime AiyionPrime marked this pull request as ready for review February 16, 2024 14:26
Mark it as expexted to fail similar to the early return contained before.
@AiyionPrime
Copy link
Contributor Author

AiyionPrime commented Feb 16, 2024

@oroulet if there's anything unclear, let me know.
Otherwise I think this is good to go as well.

It verifies loading a shelf does currently not work either, as the old test did before, but allows it to actually execute; similar to the test in #1574 before.

@AiyionPrime
Copy link
Contributor Author

@oroulet Would you mind reviewing this?

@oroulet oroulet merged commit c7d4354 into FreeOpcUa:master Feb 20, 2024
5 checks passed
@AiyionPrime AiyionPrime deleted the test/migrated_deactivated_unit_to_pytest branch February 20, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants