[xmlimporter] Support to make auto load type definitions optional #1599
+42
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To the `import_xml` an optional argument `auto_load_definitions` is added. Default is True. Case: With commit de8269e `import_xml` automatic load(on the fly code generation) the type defintions. When using your own extension object and enum implementation (with `ua.register_extension_object` `ua.register_enum`) this is unwanted behaviour. Previous work flow was: * import xml * register own extension object and enum implementations * for the remain stuff call `load_data_type_definitions()` To make this possible again an option is required to prevent the auto load definitions when calling the `import_xml` method.
bitkeeper
force-pushed
the
features/option_to_control_auto_load_definitions
branch
from
2969826 to
8c9ca2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To the
import_xmlan optional argumentauto_load_definitionsis added. Default is True.Case:
With commit de8269e
import_xmlautomatic load(on the fly code generation) the type defintions.When using your own extension object and enum implementation (with
ua.register_extension_objectua.register_enum) this is unwanted behaviour.Previous work flow was:
load_data_type_definitions()To make this possible again an option is required to prevent the auto load definitions when calling the
import_xmlmethod.