Fix MISRA C 2012 rule 20.12 deviations #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinglee-iot
force-pushed
the
fix-assert-misra
branch
from
468b0fe
to
de4652f
Compare
* Use a local variable here to prevent macro replacement is subjected to macro itself.
chinglee-iot
force-pushed
the
fix-assert-misra
branch
from
de4652f
to
70a0beb
Compare
AniruddhaKanhere
previously approved these changes
Mar 13, 2024
paulbartell
previously approved these changes
Mar 13, 2024
chinglee-iot
dismissed stale reviews from paulbartell and AniruddhaKanhere
via
ddd30bb
moninom1
approved these changes
Mar 14, 2024
shubnil
approved these changes
Mar 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MISRA C 2012 20.12 deviations
Description
MISRA C 2012 rule 20.12
assert may be implemented using a # or ## operator. In this case, macro replacement is subjected to macro itself. The result may not be meet developer expectations.
In this PR:
Test Steps
Issue #152 indicates this error.
Checklist:
I have modified and/or added unit-tests to cover the code changes in this Pull Request.Related Issue
#152
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.