Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for CMake and 64-bit builds #15

Merged
merged 9 commits into from
Jan 18, 2025

Conversation

a1batross
Copy link

Tested to work on provided maps from latest release.

CMake now properly respects install path (which I personally use everywhere, but didn't knew it's broken even in hlsdk-portable), copies binaries to featureful directory and don't force default Unix install prefix (which we don't use anywhere).

I haven't tested other platforms than linux-amd64, but they all should work as well.

@a1batross
Copy link
Author

While we're here, tested build with Clang 19.

Except that it spews tons of warnings about inconsistently missing override keyword, it works fine as well.

@FreeSlave
Copy link
Owner

Thanks!

There're a lot of HashLinks is broken messages when you open the door between monsters squads on the featureful_demo map. Could it be something with incompatibilities of the file format?

@FreeSlave
Copy link
Owner

FreeSlave commented Jan 18, 2025

Shouldn't this be a loop? Looks like only the first element is copied over

https://github.com/FWGS/hlsdk-portable/blob/0dd8f1b148f3afc310e072aec77b28a969562125/dlls/nodes.cpp#L2478

Upd: did a PR to main repo FWGS#507

@FreeSlave FreeSlave merged commit 8c254ec into FreeSlave:featureful Jan 18, 2025
5 checks passed
@a1batross
Copy link
Author

Thanks!

There're a lot of HashLinks is broken messages when you open the door between monsters squads on the featureful_demo map. Could it be something with incompatibilities of the file format?

Did you made any changes to nodes format?

This code is basically from hlsdk-portable and it should just work. It was contributed by somebody else and I'm not sure how it should work.

@FreeSlave
Copy link
Owner

@a1batross I fixed it in the PR to hlsdk-portable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants