feat: check for inNaN moved to helper

FreeTubeApp · Sep 19, 2024 · 57f251d · 57f251d
1 parent ef910f3
commit 57f251d
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/src/renderer/helpers/playlists.js b/src/renderer/helpers/playlists.js
@@ -49,10 +49,16 @@ function compareTwoPlaylistItems(a, b, sortOrder, collator) {
       return collator.compare(a.author, b.author)
     case SORT_BY_VALUES.AuthorDescending:
       return collator.compare(b.author, a.author)
-    case SORT_BY_VALUES.VideoLengthAscending:
-      return a.lengthSeconds - b.lengthSeconds
-    case SORT_BY_VALUES.VideoLengthDescending:
-      return b.lengthSeconds - a.lengthSeconds
+    case SORT_BY_VALUES.VideoLengthAscending: {
+      const aLengthForSort = (isNaN(a.lengthSeconds) || a.lengthSeconds === 0) ? 0 : a.lengthSeconds
+      const bLengthForSort = (isNaN(b.lengthSeconds) || b.lengthSeconds === 0) ? 0 : b.lengthSeconds
+      return aLengthForSort - bLengthForSort
+    }
+    case SORT_BY_VALUES.VideoLengthDescending: {
+      const aLengthForSort = (isNaN(a.lengthSeconds) || a.lengthSeconds === 0) ? 0 : a.lengthSeconds
+      const bLengthForSort = (isNaN(b.lengthSeconds) || b.lengthSeconds === 0) ? 0 : b.lengthSeconds
+      return bLengthForSort - aLengthForSort
+    }
     default:
       console.error(`Unknown sortOrder: ${sortOrder}`)
       return 0